Feat 1147 interoception #1190
Merged
Feat 1147 interoception #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saskiad
commented
Dec 10, 2024
saskiad
commented
Dec 10, 2024
saskiad
commented
Dec 10, 2024
saskiad
commented
Dec 10, 2024
dyf
requested changes
Dec 17, 2024
| @@ -415,6 +488,7 @@ class IntraperitonealInjection(Injection): | |||
| """Description of an intraperitoneal injection procedure""" | |||
|
|
|||
| procedure_type: Literal["Intraperitoneal injection"] = "Intraperitoneal injection" | |||
| procedure_time: Optional[AwareDatetimeWithDefault] = Field(default=None, title="Collection time") | |||
| procedure_type: Literal["Catheter implant"] = "Catheter implant" | ||
| protocol_id: Optional[str] = Field(default=None, title="Protocol ID", description="DOI for protocols.io") | ||
| iacuc_protocol: str = Field(..., title="IACUC protocol") | ||
| start_date: date = Field(..., title="Start date") |
There was a problem hiding this comment.
should this be procedure_time instead of start_date?
There was a problem hiding this comment.
we only have date resolution on implants - especially when they are done offsite
| class BloodCollection(AindModel): | ||
| """Description of a single blood collection""" | ||
|
|
||
| collection_time: AwareDatetimeWithDefault = Field(..., title="Collection time") |
There was a problem hiding this comment.
it's a sub-procedure. It could just be time if you prefer
dyf
reviewed
Jan 6, 2025
dyf
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1147