Update function following spikeinterface upgrade #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
reviewed
Nov 19, 2024
src/aind_ephys_rig_qc/qc_figures.py
Outdated
| @@ -190,6 +190,7 @@ def plot_drift(directory, stream_name, block_index=0): | |||
| "vmax": 0, | |||
| "cmap": "Greys_r", | |||
| "figsize": [10, 10], | |||
| "phase_shift": {"margin_ms": 100.0}, | |||
There was a problem hiding this comment.
maybe you can make phase_shift optional:
- if
"phase_shift"isNone, don't run it - else, run it with params
There was a problem hiding this comment.
Fixed in the new version by adding an editable .json file.
alejoe91
reviewed
Nov 19, 2024
src/aind_ephys_rig_qc/test.ipynb
Outdated
| @@ -0,0 +1,83 @@ | |||
| { | |||
| "cells": [ | |||
There was a problem hiding this comment.
was this file added on purpose?
There was a problem hiding this comment.
I removed this test file. It was added by accident.
|
This looks good, merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'openephys' changed to 'openephysbinary' in get_neo_streams
spikeinterface version changed to 0.101.2 in pyproject