…d7eb6d7; removed bls code warnings

- Fixed qc_chain end() iterator dereferencing and raising exceptions when some internal inconsistence in the hotstuff core is detected
- Fixed test_hotstuff failing under random conditions (e.g. use of std::vector::reserve())
- Added two alternative implementations to the qc_chain proposal store to help debug potential invalid memory access problems (choose which one to use with a #define); they show similar performance in initial benchmarks, and both seem to be working without issues; we will choose one prior to release
- Added missing variable/member initializations
- chain_pacemaker now owns and manages its qc_chain object
- Removed init() idiom and replaced with full initialization on object construction
- Refactored and simplified Pacemaker interfaces (base_pacemaker is the minimal interface that qc_chain needs, only)
- Removed exception filters in the hotstuff core (now exceptions will cause tests, and nodeos, to fail)
- Lots of miscellaneous simplifications and other improvements to the code

…ging

…main

…ace by bls_* primitive host functions.

IF: Fix deep-mind tests

IF: Merge main into hotstuff_integration

IF: Merge latest main into hotstuff_integration

…d string prefix, added base58 to_string + parsing code for bls_private_key + unit test, removed old unit test

IF: hotstuff code cleanup

- Moved everything in qc_chain.hpp that is not an interface to private:
- Fixed test_hotstuff to use get_state() instead of accessing various (now) private fields
- Fixed test_pacemaker to use get_id() instead of accessing (now) private _id field
- Added get_proposal() helper method to finalizer_state struct in chain/hotstuff.hpp since finalizer_state is now used in tests, etc.
- Made qc_chain class lock-free; all thread synchronization is now done externally
- Solved concurrency get_finalizer_state vs. qc_chain updates by caching chain_pacemaker::get_state(); zero overhead on qc_chain state updating, low overhead on external state read (no global/write locks acquired on cache hits)

- std::atomic<> _state_version & _state_cache_version
- doc _state_cache_version mutex
- qc_chain::get_id() renamed to get_id_i()
- remove mutex includes from qc_chain.hpp

- Using fc::make_scoped_exit to increment state_version in qc_chain
- const correct finalizer_state::get_proposal()

…ture

Co-authored-by: Gregory Popovitch <[email protected]>

Co-authored-by: Gregory Popovitch <[email protected]>

IF: Fix threading 1/2 (#1541) & qc_chain private:

#1541 should not be closed by this. The `_chain` pointer net vs main thread controller access will be dealt with by another PR.

Using the Github "Merge pull request" button, which should do the right thing.

IF: Use FC logging framework for better management and consistency

…imize hotstuff message sending in net_plugin.

…prefixes

…_t, 4> to remove the need to recompute the private key everytime we sign

Work in progress.

- Implemented host function (not tested);
- Finalizer set types;
- Placeholders for fc::crypto::blslib::bls_public_key operators == != and <;
- Stub notify_set_finalizers signal to be connected to chain_plugin, to reach chain_pacemaker

…eIO/leap into bls_cleanup_test_changes

- Storing set_finalizer data at controller
- chain_pacemaker retrievies set_finalizer data on get_finalizers() (not using it and not thread-safe yet)
- Fix legacy span
- Fix remove signal stub
- Fix finalizer name to string description
- Fix missing finalizer_set intrinsic whitelist upon feature activation

…or and base58 constructor

- Working ==, != and < operators in bls_public_key to enable testing this branch

Co-authored-by: Gregory Popovitch <[email protected]>

Co-authored-by: Gregory Popovitch <[email protected]>

- Tie up get_finalizer return value changes
- Better operator< for bls_public_key

Co-authored-by: Gregory Popovitch <[email protected]>

Co-authored-by: Gregory Popovitch <[email protected]>