Internal wiring of finalizers in qc chain #1615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d7eb6d7; removed bls code warnings
- Fixed qc_chain end() iterator dereferencing and raising exceptions when some internal inconsistence in the hotstuff core is detected - Fixed test_hotstuff failing under random conditions (e.g. use of std::vector::reserve()) - Added two alternative implementations to the qc_chain proposal store to help debug potential invalid memory access problems (choose which one to use with a #define); they show similar performance in initial benchmarks, and both seem to be working without issues; we will choose one prior to release - Added missing variable/member initializations - chain_pacemaker now owns and manages its qc_chain object - Removed init() idiom and replaced with full initialization on object construction - Refactored and simplified Pacemaker interfaces (base_pacemaker is the minimal interface that qc_chain needs, only) - Removed exception filters in the hotstuff core (now exceptions will cause tests, and nodeos, to fail) - Lots of miscellaneous simplifications and other improvements to the code
…-finalizer-set-transition-2
… key and signature
IF: Generate bls key pair
add set_finalizers to host functions list
use raw Affine little-endian form of g1/g2 for encoding to BLS public key and signature
…-finalizer-set-transition-2
IF: Check if input strings are invalid in conversion to public key or signature
…tion-2 IF: set_finalizers updates
…tion-3 IF: Add support to producer_plugin to load BLS finalizer keys
…ernal wiring for signing and signature verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue : #1610