-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: SHiP changes to support IBC services (adding finality_data log) #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…finality_info_support
Note:start |
…ter; add tests for previous SHiP clients interacting with new format
heifner
requested changes
Mar 21, 2024
plugins/state_history_plugin/include/eosio/state_history_plugin/session.hpp
Show resolved
Hide resolved
plugins/state_history_plugin/include/eosio/state_history_plugin/session.hpp
Outdated
Show resolved
Hide resolved
plugins/state_history_plugin/include/eosio/state_history_plugin/session.hpp
Outdated
Show resolved
Hide resolved
plugins/state_history_plugin/include/eosio/state_history_plugin/session.hpp
Show resolved
Hide resolved
heifner
approved these changes
Mar 23, 2024
greg7mdp
requested changes
Mar 26, 2024
greg7mdp
reviewed
Mar 26, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
greg7mdp
reviewed
Mar 26, 2024
This comment was marked as resolved.
This comment was marked as resolved.
greg7mdp
approved these changes
Mar 27, 2024
heifner
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new log
finality_data
is introduced toSHiP
to stream finality related data. It is enabled by option--finality-data-history
when starting aSHiP
.To fetch
finality_data
, use the new version of get_blocks_request:finality_data
contains the following data:A sample test run result looks like
Resolved #2235.