Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit apply blocks #922

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Limit apply blocks #922

merged 4 commits into from
Oct 11, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 10, 2024

  • Interrupt processing of blocks in tight apply block loop.
    • Provides much quicker shutdown during syncing.
    • Allows v1/chain/get_info calls to return quickly during syncing.
  • Restores logging every 1000 blocks during replay.

Note this takes a different approach for main than #921 does for release/1.0 because main has the optimization of not posting a handler_id::process_incoming_block if one already exists.

Resolves #284

@heifner heifner added the OCI Work exclusive to OCI team label Oct 10, 2024
@heifner heifner merged commit 5760d26 into main Oct 11, 2024
36 checks passed
@heifner heifner deleted the GH-284-partial-apply-blocks branch October 11, 2024 18:28
@ericpassmore
Copy link
Contributor

ericpassmore commented Oct 15, 2024

Note:start
category: System Stability
component: Internal
summary: Limit apply blocks.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit apply blocks time in controller
4 participants