feat: improve impersonating accounts features in core #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
feat/unlock-account
branch
from
8f535cb
to
d216a6b
Compare
Merged
4 tasks
antazoey
changed the title
fubuloubu
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I noticed some weird things with impersonating accounts... A bunch of repeated work in places.
And different ways of handling that in
send_transaction().I am working on improving all of that, but in the mean time, I need a more plugin-friendly way of impersonating accounts.
now we get to delete a bunch of code in ape-foundry and ape-hardhat.
How I did it
hence this PR, which separates the key aspect of that into a new API and has the [] access one use that
How to verify it
things work the same and able to refactor something in ape-foundry (coming soon!)
Checklist