-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: lazy source traceback in transaction errors #2211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
feat/lazier-err-tb
branch
2 times, most recently
from
August 8, 2024 18:50
96b4b33
to
119219d
Compare
fubuloubu
previously approved these changes
Aug 8, 2024
antazoey
force-pushed
the
feat/lazier-err-tb
branch
from
August 14, 2024 20:06
cfbde09
to
40aca2d
Compare
fubuloubu
previously approved these changes
Aug 14, 2024
antazoey
force-pushed
the
feat/lazier-err-tb
branch
from
August 15, 2024 17:43
40aca2d
to
a9c7847
Compare
One example of the performance gain (I am sure there are other cases): Code: %time cont.setNumber(5, sender=acct, raise_on_revert=False) Before:
After:
^ In this case it's because we are not calculated the ape-traceback because it isnt being raised, because of the |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I had a dream last night that this was the last remaining performance problem.
Basically all call-based Vm errors seems to calculate their source tbs when they don't always have to.
I am hoping by lazy-ifying this, we re-gain some of performance loss from 0.6.22
How I did it
How to verify it
Checklist