chore: drop python 3.8 support and upgrade ETH dependencies #118
Conversation
|
related to the other discussion, I wonder if these lower-level packages than ape should stay 3.8 a little bit longer, enough time for those using ape to upgrade to 0.8 where py 3.8 is dropped then we drop this closer to the deprecation date (maybe when we go v1.0 with ape) |
I am going back and forth. The main thing is I need the eth dependencies upgraded and I can't do that without also it being breaking (think Hexbytes change). So I need breaking changes releases for all these lower levels packages to even upgrade ape. I guess a chicken and egg problem. |
|
@fubuloubu OK here is a separate PR that add 3.12, so now it will support 3.8-3.12 withou breaking #119 |
antazoey
changed the title
antazoey
force-pushed
the
feat/38312
branch
2 times, most recently
from
1569c5c
to
49236ff
Compare
NotPeopling2day
force-pushed
the
feat/38312
branch
from
49236ff
to
65ae7e9
Compare
| @@ -1,4 +1,4 @@ | |||
| from typing import Iterator | |||
| from collections.abc import Iterator | |||
There was a problem hiding this comment.
what's the story behind this change? I saw this somewhere else and didn't get why
There was a problem hiding this comment.
typing is deprecated as of 3.9
https://docs.python.org/3/library/typing.html#typing.Sequence
where it introduced generic types for collections like list and dict
https://docs.python.org/3/library/stdtypes.html#types-genericalias
There was a problem hiding this comment.
typing has aliases to collections.abc but theyre deprecated. Pre python 3.9, they were required
| bytes_val = ( | ||
| self._selector_hash_fn(aitem.selector)[:4] | ||
| if isinstance(aitem, (MethodABI, ErrorABI)) | ||
| else self._selector_hash_fn(aitem.selector) |
There was a problem hiding this comment.
I think of this one as the weird one (basically for EventABI it only uses 32 bytes)
NotPeopling2day
force-pushed
the
feat/38312
branch
from
1246058
to
f0d0be2
Compare
antazoey
changed the title
antazoey
changed the title
What I did
fixes: #
How I did it
How to verify it
Checklist