Various Games: Improve custom death link option description

[SunCatMC]

What is this fixing or adding?

#3951 fixed the description in core, but of course that didn't change all the custom docstrings in various games. This PR seeks to remedy that.

How was this tested?

genned template yamls using Launcher.py

If this makes graphical changes, please attach screenshots.

blasphemous

bomb rush cyberfunc

cv64

hylics2

kh1


noita

[SunCatMC]

Seeking review from @TRPG0, @LiquidCat64, @gaithern, @ScipioWright @heinermann, @Berserker66

[Berserker66]

Subnautica change should probably just be deleting its custom text? But otherwise, the change looks fine to me.

[SunCatMC]

Subnautica change should probably just be deleting its custom text? But otherwise, the change looks fine to me.

It contains the following addition:

Note: can be toggled via in-game console command "deathlink".

so i can't remove the message without removing the addition

@Berserker66 if you are fine with that part being removed, then i can remove it
Edit: ah, i see now what you did

[heinermann]

Noita desc is fine.

[Berserker66]

Subnautica change should probably just be deleting its custom text? But otherwise, the change looks fine to me.

It contains the following addition:

Note: can be toggled via in-game console command "deathlink".

so i can't remove the message without removing the addition

fixed it in #4172

[Berserker66]

It looks like what I did in my PR should work for most if not all of the other games as well, if you want core changes to auto-propagate, instead of changing your text when core changes.

[SunCatMC]

made all possible changes auto-updating, and removed changes to subnautica in favor of #4172

[TRPG0]

Looks good for Blasphemous, Bomb Rush, Hylics 2 👍

[gaithern]

Looks good for KH1!

[LiquidCat64]

Importing the common DeathLink class into CV64's options.py causes PyCharm to throw a warning with CV64's own DeathLink class, saying "Redeclared 'DeathLink' defined above without usage", so I think it would be best to rename the CV64 DeathLink class's name to CV64DeathLink like the other changed worlds are doing. All usages of it that need updating are in options.py and rom.py (which is importing it from options.py).

[SunCatMC]

edited the class, the game did gen
can't test rom creation 'cos i don't have the rom

[LiquidCat64]

Tested the ROM sending/receiving deaths and everything is working as it should. CV64 should now be good to go in this! 👍

[Exempt-Medic]

Importing the common DeathLink class into CV64's options.py causes PyCharm to throw a warning with CV64's own DeathLink class, saying "Redeclared 'DeathLink' defined above without usage", so I think it would be best to rename the CV64 DeathLink class's name to CV64DeathLink like the other changed worlds are doing. All usages of it that need updating are in options.py and rom.py (which is importing it from options.py).

Can't you just subclass DeathLink instead?

[SunCatMC]

Importing the common DeathLink class into CV64's options.py causes PyCharm to throw a warning with CV64's own DeathLink class, saying "Redeclared 'DeathLink' defined above without usage", so I think it would be best to rename the CV64 DeathLink class's name to CV64DeathLink like the other changed worlds are doing. All usages of it that need updating are in options.py and rom.py (which is importing it from options.py).

Can't you just subclass DeathLink instead?

how would you turn a DeathLink Toggle into a Choice via subclassing?

[Exempt-Medic]

how would you turn a DeathLink Toggle into a Choice via subclassing?

Oh 🤦

[ScipioWright]

Noita's looks good now