EMSUSD-243 load reference and payload without default prim #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Jun 30, 2023
pierrebai-adsk
commented
- Refactor add reference and add payload commands into a common base class.
- (The code were almost similar and now have even more in common.)
- Add validation of the ref or payload targeted prim to catch common errors.
- For example, the targeted prim must have the same type as the referencing prim.
- For example: an xform inside an xform, a mesh inside a mesh.
- Target the first valid root prim when no explicit prim were given and there is no default prim.
- Add warnings for common errors to help the user know what went wrong.
- Add a unit test for files without default prim.
pierrebai-adsk
added
do-not-merge-yet
Base automatically changed from
bailp/MAYA-129538/move-context-commands-to-usdufe
to
dev
July 4, 2023 15:40
pierrebai-adsk
removed
the
do-not-merge-yet
- Refactor add reference and add payload commands into a common base class. - (The code were almost similar and now have even more in common.) - Add validation of the ref or payload targeted prim to catch common errors. - For example, the targeted prim must have the same type as the referencing prim. - For example: an xform inside an xform, a mesh inside a mesh. - Target the first valid root prim when no explicit prim were given and there is no default prim. - Add warnings for common errors to help the user know what went wrong. - Add a unit test for files without default prim.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-243/ref-without-default-prim
branch
from
df8805b
to
2702f27
Compare
pierrebai-adsk
commented
Jul 4, 2023
| // If no prim path were specified and we are referencing a MaterialX file | ||
| // then use the MaterialX prim as the target for the reference. | ||
| // | ||
| // TODO: should we force this even when the referenced file has a default prim? |
There was a problem hiding this comment.
The code that this refactor was already doing this. It was added as part of the LookDevX effort. We can revisit (that is remove) this once we have a UI to specify the prim we want to load.
vlasovi
reviewed
Jul 4, 2023
- First we print a status message that there is no default prim and that we wwill use the first valid prim. - Afterwards, if no valid root prim is found, we print a warning about why we could not find a valid root prim.
vlasovi
reviewed
Jul 4, 2023
vlasovi
approved these changes
Jul 4, 2023
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.