Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMSUSD-243 load reference and payload without default prim #3190

Merged
merged 3 commits into from
Jul 5, 2023
Merged

EMSUSD-243 load reference and payload without default prim #3190

merged 3 commits into from
Jul 5, 2023

Commits on Jul 4, 2023

  1. EMSUSD 243 load reference and payload without default prim 

    - Refactor add reference and add payload commands into a common base class.
- (The code were almost similar and now have even more in common.)
- Add validation of the ref or payload targeted prim to catch common errors.
- For example, the targeted prim must have the same type as the referencing prim.
- For example: an xform inside an xform, a mesh inside a mesh.
- Target the first valid root prim when no explicit prim were given and there is no default prim.
- Add warnings for common errors to help the user know what went wrong.
- Add a unit test for files without default prim.
    @pierrebai-adsk
    pierrebai-adsk committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2702f27 View commit details
    Browse the repository at this point in the history

  2. EMSUSD-243 split warning when there is no default prim. 

    - First we print a status message that there is no default prim and that we wwill use the first valid prim.
- Afterwards, if no valid root prim is found, we print a warning about why we could not find a valid root prim.
    @pierrebai-adsk
    pierrebai-adsk committed Jul 4, 2023
    1 Configuration menu
    Copy the full SHA
    7912e8c View commit details
    Browse the repository at this point in the history

  3. EMSUSD-243 fixing warning arguments order.

    @pierrebai-adsk
    pierrebai-adsk committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    e3b0935 View commit details
    Browse the repository at this point in the history