Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-190 fix for lights after edit-as-Maya #3198

Merged
merged 6 commits into from
Jul 11, 2023

Commits on Jul 4, 2023

  1. EMSUSD-190 dding missing UFE notification after re-adding the edited …

    …object
    
    The new code mirror what is done in edit-as-Maya when the object transtions from being USD to being Maya. When it did, the UFE light proxy in Maya was deleted,  and the missing notification in merge-to-USD was preventing the proxy from being recreated.
    pierrebai-adsk committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    c7c40ac View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. EMSUSD-190 fix the default parent

    - No longer send an explicit add notification for the item that was converted from Maya to USD.
    - Call the parent function instead of the defaultParent function. We only need to invalidate the scene from the point where the object were edited.
    - When calling defaultParent, the entire Maya cene would be invalidated.
    - Change the implementation of the proxy shape default parent since it is a Maya node, its default parent must also be a Maya node.
    - Fortunately, the old behavior was only used when reparenting and one cannot change the location of the USD virtual root, so the old bahavior was never used in  practice, as far as I can tell.
    pierrebai-adsk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c954f28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    91c9e61 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Configuration menu
    Copy the full SHA
    92f0f0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee65e6e View commit details
    Browse the repository at this point in the history
  3. Merge branch 'bailp/EMSUSD-190/lost-light' of github.com:Autodesk/may…

    …a-usd into bailp/EMSUSD-190/lost-light
    pierrebai-adsk committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    6025f14 View commit details
    Browse the repository at this point in the history