EMSUSD-190 fix for lights after edit-as-Maya #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…object The new code mirror what is done in edit-as-Maya when the object transtions from being USD to being Maya. When it did, the UFE light proxy in Maya was deleted, and the missing notification in merge-to-USD was preventing the proxy from being recreated.
vlasovi
previously approved these changes
Jul 5, 2023
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
reviewed
Jul 5, 2023
pierrebai-adsk
removed
the
ready-for-merge
- No longer send an explicit add notification for the item that was converted from Maya to USD. - Call the parent function instead of the defaultParent function. We only need to invalidate the scene from the point where the object were edited. - When calling defaultParent, the entire Maya cene would be invalidated. - Change the implementation of the proxy shape default parent since it is a Maya node, its default parent must also be a Maya node. - Fortunately, the old behavior was only used when reparenting and one cannot change the location of the USD virtual root, so the old bahavior was never used in practice, as far as I can tell.
seando-adsk
reviewed
Jul 5, 2023
seando-adsk
previously approved these changes
Jul 5, 2023
pierrebai-adsk
added
the
ready-for-merge
|
The only change sin cethe last approval is I only merged dev branch into this branch. |
seando-adsk
previously approved these changes
Jul 10, 2023
pierrebai-adsk
removed
the
ready-for-merge
…a-usd into bailp/EMSUSD-190/lost-light
seando-adsk
approved these changes
Jul 10, 2023
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing UFE notification after re-adding the edited object
The new code mirror what is done in edit-as-Maya when the object transtions from being USD to being Maya. When it did, the UFE light proxy in Maya was deleted, and the missing notification in merge-to-USD (and discard-edits) was preventing the proxy from being recreated.