Update supported PHP version to 7.4 and WP 5.9 minimum #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other than developer convenience, what's the benefit here? What feature of PHP 7.4 are deemed essential? (This would be a breaking change, so a major release would be needed - if that's not desirable at this time when only 8.1 support is being added, then now is not the time to bump minimum supported PHP). |
GaryJones
requested changes
Aug 18, 2023
| @@ -11,7 +11,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=5.6", | |||
| "php": ">=7.4", | |||
There was a problem hiding this comment.
Even if this change was deemed desirable not (I don't think it is), then I'd also expect changes to readme, CI, and Requires PHP plugin header.
mchanDev
changed the title
GaryJones
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.