Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported PHP version to 7.4 and WP 5.9 minimum #175

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Update supported PHP version to 7.4 and WP 5.9 minimum #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
011ca8e
Update supported PHP version to 7.4 minimum
mchanDev Aug 18, 2023
1bea1fe
Update minimum php version across CI, plugin header, and Github actio…
mchanDev Nov 15, 2023
af02502
Add php 8 versions to github actions tests
mchanDev Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/integrations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
strategy:
matrix:
wordpress: ["5.5", "5.6", "5.7"]
php: ["5.6", "7.0", "7.1", "7.2", "7.3", "7.4"]
php: ["7.4", "8.0", "8.1"]
include:
- php: "8.0"
# Ignore platform requirements, so that PHPUnit 7.5 can be installed on PHP 8.0 (and above).
Expand Down
2 changes: 1 addition & 1 deletion .phpcs.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<rule ref="PHPCompatibilityWP"/>
<!-- For help in understanding this testVersion:
https://github.com/PHPCompatibility/PHPCompatibility#sniffing-your-code-for-compatibility-with-specific-php-versions -->
<config name="testVersion" value="5.6-"/>
<config name="testVersion" value="7.4-"/>

<!-- Rules: WordPress Coding Standards - see
https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards -->
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
}
],
"require": {
"php": ">=5.6",
"php": ">=7.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if this change was deemed desirable not (I don't think it is), then I'd also expect changes to readme, CI, and Requires PHP plugin header.

"composer/installers": "~1.0"
},
"require-dev": {
Expand Down
1 change: 1 addition & 0 deletions msm-sitemap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
Version: 1.4.1
Stable tag: 1.4.1
License: GPLv2
Requires PHP: 7.4
*/

if ( defined( 'WP_CLI' ) && true === WP_CLI ) {
Expand Down
Loading