Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-distribution): Improve CSS for blocked editor #193

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

naxoc
Copy link
Member

@naxoc naxoc commented Jan 20, 2025

This fixes 2 things that came out of #181

  • Also blocks the "Featured image" button so that is not editable on linked posts
  • Fixes a bug where it was not possible to click from the "Block" tab in the sidebar to the "Post" tab.

How to test

On a linked post – ensure that the sidebar blocks what it should (and no more) and that you can click between the tabs in the sidebar.

This fixes 2 things that came out of #181

* Also blocks the "Featured image" button so that is not editable on
linked posts
* Fixes a bug where it was not possible to click from the "Block" tab in
the sidebar to the "Post" tab.

## How to test
On a linked post – ensure that the sidebar blocks what it should (and no
more) and that you can click between the tabs in the sidebar.
@naxoc naxoc requested a review from miguelpeixe January 20, 2025 10:31
@naxoc naxoc self-assigned this Jan 20, 2025
@naxoc naxoc requested a review from a team as a code owner January 20, 2025 10:31
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@naxoc naxoc merged commit 295bdad into trunk Jan 20, 2025
4 checks passed
@naxoc naxoc deleted the fix/content-distribution-panel-css branch January 20, 2025 13:15
Copy link

Hey @naxoc, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants