Studio: Update electron-forge to the latest version 7.6.0 #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightnei
force-pushed
the
nightnei/updateElectronForge
branch
from
7c94f89 to
e53605c
Compare
nightnei
changed the title
nightnei
commented
Jan 9, 2025
| @@ -55,6 +55,7 @@ const config: ForgeConfig = { | |||
| ? [] | |||
| : [ | |||
| new MakerDMG( | |||
| // @ts-expect-error - https://github.com/electron/forge/issues/3712 | |||
There was a problem hiding this comment.
There is bug in the MakerDMG - appPath is required by mistake, and it should be optional in the next release. So we will remove this @ts-expect-error when it's fixed.
There was a problem hiding this comment.
The bug is closed. Does it mean it was not released yet?
wojtekn
approved these changes
Jan 10, 2025
| @@ -55,6 +55,7 @@ const config: ForgeConfig = { | |||
| ? [] | |||
| : [ | |||
| new MakerDMG( | |||
| // @ts-expect-error - https://github.com/electron/forge/issues/3712 | |||
There was a problem hiding this comment.
The bug is closed. Does it mean it was not released yet?
nightnei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Here we reverted electron-forge to 7.3.1, but the actual issue was connected not to electron-forge, it was about
@electron/packager, which we pinned to18.1.3version. So actually, there is no sense to keep pinned both -electron-forgeand@electron/packager. As a result, since@electron/packageris anyway has pinned version, then we are safe to continue updatingelectron-forgeto new versions, as long as it works well.With this PR I propose to update electron-forge to the latest version and create a new issue to remove overrides for "@electron/packager": "18.1.3", when the package is fixed.
In the history of commits of this PR you can see that if we unpin override for @electron/packager then it has still the old error. And actually the open issue confirms that the issue still exists.
And I tested - the latest electron-forge works well.
Testing Instructions
npm start)npm run make./outdirectoryWindows Dev Build)