Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio: Update electron-forge to the latest version 7.6.0 #795

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Studio: Update electron-forge to the latest version 7.6.0 #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fd8459
chore(package.json): update electron-forge to latest version 7.6.1
nightnei Jan 9, 2025
f6c0030
chore: space
nightnei Jan 9, 2025
e53605c
chore: test removing overrides for electron-packager
nightnei Jan 9, 2025
79a2168
chore: revert testing broken Windows
nightnei Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions forge.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ const config: ForgeConfig = {
? []
: [
new MakerDMG(
// @ts-expect-error - https://github.com/electron/forge/issues/3712
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is bug in the MakerDMG - appPath is required by mistake, and it should be optional in the next release. So we will remove this @ts-expect-error when it's fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug is closed. Does it mean it was not released yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They made it here optional, but looks like it wasn't in 7.6.0 release (according to this comment)

{
icon: 'assets/studio-app-icon.icns',
background: 'assets/dmg-background.png',
Expand Down
Loading
Loading