Add option to save first samples of peak(lets) waveform #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
This PR adds the option to save the first n (default to 200) samples of the merged peak(lets) waveform without downsampling. In case of very wide S1s or S1s with a lot of afterpulses strax will downsample the peak waveforms to fit into the 200 sample summed waveform that we save with peaklets and peaks. This process removes important information of the S1 waveform. With this PR the first n samples of the waveforms are saved for peaklets that 1. get downsampled and 2. have a downsampling factor smaller 7. This should cover basically all S1s without introducing a large file size overhead.