Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add availability zones Bicep parameter #108

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

sebassem
Copy link
Contributor

Pull Request

Issue

Issue #103 and #102

Description

Adding a new private function to determine the availability zones for the selected regions and edit the parameters files of the relevant networking modules to include them by default.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@oZakari
Copy link
Contributor

oZakari commented Mar 18, 2024

Thanks so much @sabassem for your work with this!

Hi @jaredfholgate, is it okay with you at this point if we merge this and create a release or are you still running tests for your work?

@jaredfholgate
Copy link
Member

@oZakari and @sebassem Although the code is all ready to go, I have not had chance to update the customer facing docs in the Bicep and Terraform Accelerator repos. I intend to do that tomorrow. I'd ideally like to wait for that before cutting the release if you can wait another day or two?

@oZakari
Copy link
Contributor

oZakari commented Mar 18, 2024

@jaredfholgate, for sure, this is just something we want to try to get out by the end of this sprint so no need to rush to get it done in the next couple of days or anything.

@oZakari oZakari merged commit 79d7c6d into Azure:main Mar 21, 2024
2 checks passed
@sebassem sebassem deleted the bicep-availability-zones branch August 12, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants