Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{storagesync} Remove ADAL dependencies #7933

Merged
merged 3 commits into from
Sep 3, 2024
Merged

{storagesync} Remove ADAL dependencies #7933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d031e5c
remove msrestazure
cxznmhdcxz Aug 28, 2024
0c66a10
update version
cxznmhdcxz Aug 29, 2024
a500391
recording
cxznmhdcxz Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/storagesync/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
Release History
===============

1.0.1
++++++
* Remove ADAL dependencies

1.0.0
++++++
* Add `az storagesync check-name-availability`
Expand Down
6 changes: 3 additions & 3 deletions src/storagesync/azext_storagesync/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@


def parse_storage_sync_service(namespace):
from msrestazure.tools import is_valid_resource_id, parse_resource_id
from azure.mgmt.core.tools import is_valid_resource_id, parse_resource_id

if namespace.storage_sync_service_name and is_valid_resource_id(namespace.storage_sync_service_name):
namespace.resource_group_name = parse_resource_id(namespace.storage_sync_service_name)['resource_group']
Expand All @@ -14,7 +14,7 @@ def parse_storage_sync_service(namespace):

def parse_server_id(cmd, namespace):
from azure.cli.core.commands.client_factory import get_subscription_id
from msrestazure.tools import is_valid_resource_id, resource_id
from azure.mgmt.core.tools import is_valid_resource_id, resource_id

if namespace.server_resource_id and not is_valid_resource_id(namespace.server_resource_id):
namespace.server_resource_id = resource_id(
Expand All @@ -30,7 +30,7 @@ def parse_server_id(cmd, namespace):

def parse_storage_account(cmd, namespace):
from azure.cli.core.commands.client_factory import get_subscription_id
from msrestazure.tools import is_valid_resource_id, resource_id
from azure.mgmt.core.tools import is_valid_resource_id, resource_id

if namespace.storage_account_resource_id:
if not is_valid_resource_id(namespace.storage_account_resource_id):
Expand Down
10 changes: 5 additions & 5 deletions src/storagesync/azext_storagesync/tests/latest/recordings/test_storagesync.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/storagesync/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

# TODO: Confirm this is the right version number you want and it matches your
# HISTORY.rst entry.
VERSION = '1.0.0'
VERSION = '1.0.1'

# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
Expand Down
Loading