Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Changes to Fix Concurrency Issues #4020

Closed

Conversation

kundadebdatta
Copy link
Member

@kundadebdatta kundadebdatta commented Aug 8, 2023

Pull Request Template

Description

  1. Validate only the Unhealthy replicas, and remove the Unknown ones from validation.
  2. Add a mechanism to get hold of a connection health state, to detect any established connection before attempting to open new connections.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #IssueNumber

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@kundadebdatta kundadebdatta self-assigned this Aug 9, 2023
@@ -1006,7 +1023,6 @@ private static string ProtocolString(Protocol protocol)
.Where(address => address
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to invest some time to check the perf of the dictionary creation and maintaining for a large partition. Ideally the size should be constant and proportional to the number of partitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant