Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed Changes to Fix Concurrency Issues #4020

Closed
wants to merge 8 commits into from
Closed

Proposed Changes to Fix Concurrency Issues #4020

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
726e9ac
Code changes to fix concurrency issues.
kundadebdatta Aug 6, 2023
abfcdcc
Required code changes for CTL config.
kundadebdatta Aug 7, 2023
29f499d
Revert "Code changes to fix concurrency issues."
kundadebdatta Aug 7, 2023
5545f81
Revert "Revert "Code changes to fix concurrency issues.""
kundadebdatta Aug 7, 2023
bf1b812
Code changes to fix concurrency issues.
kundadebdatta Aug 8, 2023
1f6327d
Code changes to refactor channel dictionary.
kundadebdatta Aug 10, 2023
0179b5f
Code changes to add task pool validation for concurrent requests.
kundadebdatta Aug 19, 2023
321409c
Code changes to make test more effective. Refactored background task …
kundadebdatta Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Microsoft.Azure.Cosmos.Samples/Tools/CTL/CTLConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ internal CosmosClient CreateCosmosClient()
CosmosClientOptions clientOptions = new CosmosClientOptions()
{
ApplicationName = CTLConfig.UserAgentSuffix,
EnableClientTelemetry = true
};

if (this.UseGatewayMode)
Expand Down
10 changes: 2 additions & 8 deletions Microsoft.Azure.Cosmos.Samples/Tools/CTL/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,7 @@ await scenario.InitializeAsync(
logger: logger);

logger.LogInformation("Initialization completed.");

if(client.ClientOptions.EnableClientTelemetry.GetValueOrDefault()) {
logger.LogInformation("Telemetry is enabled for CTL.");
} else {
logger.LogInformation("Telemetry is disabled for CTL.");
}
logger.LogInformation("Telemetry is disabled for CTL.");

List<Task> tasks = new List<Task>
{
Expand Down Expand Up @@ -150,8 +145,7 @@ await scenario.InitializeAsync(

private static void SetEnvironmentVariables(CTLConfig config)
{
Environment.SetEnvironmentVariable(ClientTelemetryOptions.EnvPropsClientTelemetryEndpoint, config.TelemetryEndpoint);
Environment.SetEnvironmentVariable(ClientTelemetryOptions.EnvPropsClientTelemetrySchedulingInSeconds, config.TelemetryScheduleInSeconds);
Environment.SetEnvironmentVariable("AZURE_COSMOS_REPLICA_VALIDATION_ENABLED", "True");
}

private static IMetricsRoot ConfigureReporting(
Expand Down
12 changes: 1 addition & 11 deletions Microsoft.Azure.Cosmos.Samples/Tools/CTL/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,17 +173,7 @@ public static void LogDiagnostics(
CosmosDiagnostics cosmosDiagnostics)
{

if (timerContextLatency > config.DiagnosticsThresholdDurationAsTimespan)
{
logger.LogInformation($"{operationName}; LatencyInMs:{timerContextLatency.TotalMilliseconds}; request took more than latency threshold {config.DiagnosticsThresholdDuration}, diagnostics: {cosmosDiagnostics}");
}

CosmosTraceDiagnostics traceDiagnostics = (CosmosTraceDiagnostics)cosmosDiagnostics;
if (traceDiagnostics.IsGoneExceptionHit())
{
logger.LogInformation($"{operationName}; LatencyInMs:{timerContextLatency.TotalMilliseconds}; request contains 410(GoneExceptions), diagnostics:{cosmosDiagnostics}");
return;
}
logger.LogInformation($"{operationName}; LatencyInMs:{timerContextLatency.TotalMilliseconds}; diagnostics: {cosmosDiagnostics}");
}

public static void LogError(
Expand Down
Loading
Loading