Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Remove parameter DockerBridgeCidr from New-AzAksCluster #23063

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

YanaXu
Copy link
Contributor

@YanaXu YanaXu commented Oct 24, 2023

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 24, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Aks
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@VeryEarly VeryEarly self-assigned this Oct 25, 2023
Copy link
Contributor

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refresh help markdown for New-AzAksCluster

@YanaXu
Copy link
Contributor Author

YanaXu commented Oct 26, 2023

please refresh help markdown for New-AzAksCluster

Done. Thanks.

@VeryEarly VeryEarly merged commit 9f02194 into main Oct 30, 2023
12 checks passed
@VeryEarly VeryEarly deleted the yanxu/aks branch October 30, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants