Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Remove parameter DockerBridgeCidr from New-AzAksCluster #23063

Merged
merged 2 commits into from
Oct 30, 2023
Merged

[AKS] Remove parameter DockerBridgeCidr from New-AzAksCluster #23063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d6f7b4
remove parameter DockerBridgeCidr from New-AzAksCluster
YanaXu Oct 24, 2023
d676c72
update help md
YanaXu Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Aks/Aks/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Removed parameter `DockerBridgeCidr` from `New-AzAksCluster`

## Version 5.5.1
* Fixed the issue of handling `nextLink` in `Set-AzAksCluster`. [#21846]
Expand Down
4 changes: 0 additions & 4 deletions src/Aks/Aks/Commands/NewAzureRmAks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,6 @@ public class NewAzureRmAks : CreateOrUpdateKubeBase
[Parameter(Mandatory = false, HelpMessage = "DNS service IP used for building Kubernetes network.")]
public string DnsServiceIP { get; set; }

[CmdletParameterBreakingChangeWithVersion("DockerBridgeCidr", "11.0.0", "6.0.0", ChangeDescription = "DockerBridgeCidr parameter will be deprecated in Az 11.0.0 without being replaced.")]
[Parameter(Mandatory = false, HelpMessage = "Docker bridge cidr used for building Kubernetes network.")]
public string DockerBridgeCidr { get; set; }

[Parameter(Mandatory = false, HelpMessage = "The outbound (egress) routing method.")]
[PSArgumentCompleter("loadBalancer", "userDefinedRouting", "managedNATGateway", "userAssignedNATGateway")]
public string OutboundType { get; set; }
Expand Down
21 changes: 3 additions & 18 deletions src/Aks/Aks/help/New-AzAksCluster.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ New-AzAksCluster [-NodeVmSetType <String>] [-NodeVnetSubnetID <String>] [-NodeMa
[-NodeScaleSetEvictionPolicy <String>] [-AddOnNameToBeEnabled <String[]>] [-WorkspaceResourceId <String>]
[-SubnetName <String>] [-EnableRbac] [-WindowsProfileAdminUserName <String>] [-NetworkPlugin <String>]
[-NetworkPolicy <String>] [-PodCidr <String>] [-ServiceCidr <String>] [-DnsServiceIP <String>]
[-DockerBridgeCidr <String>] [-OutboundType <String>] [-LoadBalancerSku <String>] [-Force] [-GenerateSshKey]
[-EnableNodePublicIp] [-NodePublicIPPrefixID <String>] [-AvailabilityZone <String[]>]
[-NodeResourceGroup <String>] [-EnableEncryptionAtHost] [-EnableUltraSSD] [-NodeLinuxOSConfig <LinuxOSConfig>]
[-OutboundType <String>] [-LoadBalancerSku <String>] [-Force] [-GenerateSshKey] [-EnableNodePublicIp]
[-NodePublicIPPrefixID <String>] [-AvailabilityZone <String[]>] [-NodeResourceGroup <String>]
[-EnableEncryptionAtHost] [-EnableUltraSSD] [-NodeLinuxOSConfig <LinuxOSConfig>]
[-NodeKubeletConfig <KubeletConfig>] [-NodeMaxSurge <String>] [-PPG <String>] [-EnableFIPS]
[-AutoScalerProfile <ManagedClusterPropertiesAutoScalerProfile>] [-GpuInstanceProfile <String>]
[-EnableUptimeSLA] [-EdgeZone <String>] [-NodeHostGroupID <String>] [-NodePodSubnetID <String>]
Expand Down Expand Up @@ -366,21 +366,6 @@ Accept pipeline input: False
Accept wildcard characters: False
```

### -DockerBridgeCidr
Docker bridge cidr used for building Kubernetes network.

```yaml
Type: System.String
Parameter Sets: (All)
Aliases:

Required: False
Position: Named
Default value: None
Accept pipeline input: False
Accept wildcard characters: False
```

### -EdgeZone
The name of the Edge Zone.

Expand Down
3 changes: 3 additions & 0 deletions tools/StaticAnalysis/Exceptions/Az.Aks/BreakingChangeIssues.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,6 @@
"Az.Aks","Microsoft.Azure.Commands.Aks.SetAzureRmAks","Set-AzAksCluster","0","3010","The property 'ClientAppID' of type 'Microsoft.Azure.Management.ContainerService.Models.ManagedClusterAADProfile' has been removed.","Add the property 'ClientAppID' back to type 'Microsoft.Azure.Management.ContainerService.Models.ManagedClusterAADProfile'."
"Az.Aks","Microsoft.Azure.Commands.Aks.SetAzureRmAks","Set-AzAksCluster","0","3010","The property 'ServerAppID' of type 'Microsoft.Azure.Management.ContainerService.Models.ManagedClusterAADProfile' has been removed.","Add the property 'ServerAppID' back to type 'Microsoft.Azure.Management.ContainerService.Models.ManagedClusterAADProfile'."
"Az.Aks","Microsoft.Azure.Commands.Aks.SetAzureRmAks","Set-AzAksCluster","0","3010","The property 'TenantID' of type 'Microsoft.Azure.Management.ContainerService.Models.ManagedClusterAADProfile' has been removed.","Add the property 'TenantID' back to type 'Microsoft.Azure.Management.ContainerService.Models.ManagedClusterAADProfile'."
"Az.Aks","Microsoft.Azure.Commands.Aks.NewAzureRmAks","New-AzAksCluster","0","2000","The cmdlet 'New-AzAksCluster' no longer supports the parameter 'DockerBridgeCidr' and no alias was found for the original parameter name.","Add the parameter 'DockerBridgeCidr' back to the cmdlet 'New-AzAksCluster', or add an alias to the original parameter name."
"Az.Aks","Microsoft.Azure.Commands.Aks.NewAzureRmAks","New-AzAksCluster","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzAksCluster' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzAksCluster'."
"Az.Aks","Microsoft.Azure.Commands.Aks.NewAzureRmAks","New-AzAksCluster","0","1050","The parameter set 'defaultParameterSet' for cmdlet 'New-AzAksCluster' has been removed.","Add parameter set 'defaultParameterSet' back to cmdlet 'New-AzAksCluster'."