[#74] react-helmet 적용 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChoiWonBeen
approved these changes
Feb 29, 2024
| <Route path="/bus" element={<BusPage />} /> | ||
| <Route path="/cafeteria" element={<CafeteriaPage />} /> | ||
| <Route path="/board/notice" element={<NoticePage />}> | ||
| <Route path="timetable" element={<HelmetWrapper title="코인 - 시간표" element={<TimetablePage />} />} /> |
There was a problem hiding this comment.
어차피 모든 Route에 헬멧을 담아야한다면 Route까지 래핑하는건 어려웟을까요?
There was a problem hiding this comment.
제가 늦게 확인했네요 배포 이후 작업으로 진행하겠습니다.
This reverts commit 9c7b1bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#74] request
react-helmet을 통한 title 변경
Please check if the PR fulfills these requirements
developbranch, not themainbranchyarn lintScreenshot