-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#74] react-helmet 적용 #75
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7763d5d
chore: react-helmet 추가
daepan 61acb6b
feat: react-helmet 컴포넌트 세팅
daepan 4292133
chore: react-helmet 설치 에러 수정
daepan 54b61f9
feat: 로그인 페이지 Helmet 추가
daepan d601b80
feat: react-helmet 제거
daepan 352b916
chore: react-helmet 추가
daepan 27f182d
Revert "chore: react-helmet 설치 에러 수정"
daepan 32750e5
yarn clear
d570b36
fix: yarn error 수정
daepan 42789c4
chore: react-helmet 라이브러리 추가
daepan ce648f0
feat: 코인 웹페이지 react-helmet title 적용
daepan 8075a65
feat: 잘못된 적용 수정
daepan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
yarnPath: .yarn/releases/yarn-3.8.0.cjs | ||
compressionLevel: mixed | ||
|
||
enableGlobalCache: false | ||
|
||
yarnPath: .yarn/releases/yarn-3.8.0.cjs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/* eslint-disable react/require-default-props */ | ||
import { Helmet } from 'react-helmet'; | ||
|
||
type MetaHelmetProps = { | ||
title: string, | ||
description?: string, | ||
image?: string, | ||
}; | ||
|
||
export default function MetaHelmet({ | ||
title = '코인 - 한기대 커뮤니티', // 기본값을 직접 할당 | ||
description = '보다 편하게, 한국기술교육대학교 생활에 필요한 서비스를 만날 수 있습니다.', | ||
image = 'https://static.koreatech.in/assets/img/facebook_showcase_image.png', | ||
}: MetaHelmetProps) { | ||
return ( | ||
<Helmet> | ||
<title>{title}</title> | ||
<meta name="description" content={description} /> | ||
<meta name="og:title" content={title} /> | ||
<meta | ||
name="og:description" | ||
content={description} | ||
/> | ||
<meta | ||
property="og:image" | ||
content={image} | ||
/> | ||
<meta property="og:image:width" content="1200" /> | ||
</Helmet> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어차피 모든 Route에 헬멧을 담아야한다면 Route까지 래핑하는건 어려웟을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 늦게 확인했네요 배포 이후 작업으로 진행하겠습니다.