Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Julia compat to 1.6 #293

Closed
wants to merge 1 commit into from

Conversation

jakobnissen
Copy link
Member

We actually didn't support Julia 1.5, and didn't test on it, so it was a mistake to have claimed to have supported earlier versions.

We actually didn't support Julia 1.5, and didn't test on it, so it was a mistake
to have claimed to have supported earlier versions.
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4038670) 91.06% compared to head (355b62b) 91.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files          31       31           
  Lines        2395     2395           
=======================================
  Hits         2181     2181           
  Misses        214      214           
Flag Coverage Δ
unittests 91.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakobnissen
Copy link
Member Author

I was wrong - it DOES run on Julia 1.5. See #294

@jakobnissen jakobnissen deleted the julia_compat branch October 16, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant