-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ispalindromic
#304
Update ispalindromic
#304
Conversation
Expand the documentation to explain that it is palindromic with respect to the reverse-complement. Also implement a fast-path for 2-bit nucleotides.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 90.89% 90.91% +0.01%
==========================================
Files 31 31
Lines 2395 2400 +5
==========================================
+ Hits 2177 2182 +5
Misses 218 218
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/biosequence/predicates.jl
Outdated
return false | ||
end | ||
end | ||
_ispalindromic(seq) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to insert 4-spaces instead of a TAB-character here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops yes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Expand the documentation to explain that it is palindromic with respect to the reverse-complement. Also implement a fast-path for 2-bit nucleotides.
See #303 - thanks, @Seelengrab