Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ispalindromic #304

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Update ispalindromic #304

merged 2 commits into from
Mar 22, 2024

Conversation

jakobnissen
Copy link
Member

Expand the documentation to explain that it is palindromic with respect to the reverse-complement. Also implement a fast-path for 2-bit nucleotides.

See #303 - thanks, @Seelengrab

Expand the documentation to explain that it is palindromic with respect to the
reverse-complement. Also implement a fast-path for 2-bit nucleotides.
@jakobnissen jakobnissen linked an issue Mar 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (56d9ab5) to head (8ebf461).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   90.89%   90.91%   +0.01%     
==========================================
  Files          31       31              
  Lines        2395     2400       +5     
==========================================
+ Hits         2177     2182       +5     
  Misses        218      218              
Flag Coverage Δ
unittests 90.91% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return false
end
end
_ispalindromic(seq)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to insert 4-spaces instead of a TAB-character here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops yes!

Copy link
Member

@kescobo kescobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jakobnissen jakobnissen merged commit 95d9218 into BioJulia:master Mar 22, 2024
27 checks passed
@jakobnissen jakobnissen deleted the palindromic branch March 22, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ispalindromic with respect to reverse or reverse_complement?
3 participants