Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various internal code cleanup #323

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

jakobnissen
Copy link
Member

  • Remove some unused, internal functions
  • Use trailing_zeros instead of LUT for 4->2 bit transcoding
  • Remove validity check when encoding, since invalid biosymbols should never exist
  • Remove some small source code files, and move their content to other files
  • Optimise a commonly used bitindex method
  • Optimise equality for SeqOrView of identical alphabets

* Remove some unused, internal functions
* Use `trailing_zeros` instead of LUT for 4->2 bit transcoding
* Remove validity check when encoding, since invalid biosymbols should never
  exist
* Remove some small source code files, and move their content to other files
* Optimise a commonly used bitindex method
* Optimise equality for SeqOrView of identical alphabets
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.06%. Comparing base (95d9218) to head (e8215a1).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/bit-manipulation/bitindex.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   90.87%   91.06%   +0.18%     
==========================================
  Files          31       28       -3     
  Lines        2400     2506     +106     
==========================================
+ Hits         2181     2282     +101     
- Misses        219      224       +5     
Flag Coverage Δ
unittests 91.06% <96.29%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakobnissen jakobnissen merged commit 8fa5616 into BioJulia:master Oct 24, 2024
22 checks passed
@jakobnissen jakobnissen deleted the cleanup branch October 24, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant