Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bioschemas property web pages to prevent 404 errors on profiles #792

Merged
merged 10 commits into from
Nov 1, 2023
Merged

Bioschemas property web pages to prevent 404 errors on profiles #792

merged 10 commits into from
Nov 1, 2023

Conversation

albangaignard
Copy link
Contributor

No description provided.

@albangaignard albangaignard self-assigned this Oct 9, 2023
@albangaignard albangaignard marked this pull request as draft October 9, 2023 11:23
@albangaignard albangaignard marked this pull request as ready for review November 1, 2023 13:51
@albangaignard albangaignard requested review from gtsueng and removed request for bedroesb November 1, 2023 15:09
@albangaignard
Copy link
Contributor Author

New menu item for properties :
Capture d’écran 2023-11-01 à 17 40 25

@albangaignard
Copy link
Contributor Author

New template to render the (flat) list of properties :
Capture d’écran 2023-11-01 à 17 41 10

@albangaignard
Copy link
Contributor Author

albangaignard commented Nov 1, 2023 •
edited
Loading

New template for each property

Sample URL : http://localhost:4000/properties/input
Localhost would be replaced by bioschemas.org

Capture d’écran 2023-11-01 à 17 41 43

@albangaignard
Copy link
Contributor Author

Fixed property links to point to the appropriate Bioschemas property page :
Capture d’écran 2023-11-01 à 17 43 17

nsjuty
nsjuty approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@nsjuty nsjuty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nsjuty
Copy link
Contributor

nsjuty commented Nov 1, 2023

All previews look good

@nsjuty nsjuty closed this Nov 1, 2023
@albangaignard albangaignard merged commit 22db89b into master Nov 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsjuty nsjuty nsjuty approved these changes

@ljgarcia ljgarcia Awaiting requested review from ljgarcia

@gtsueng gtsueng Awaiting requested review from gtsueng

Assignees

@albangaignard albangaignard

Labels
prior: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albangaignard @nsjuty