Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1 MS deplay to CleanUpDb to allow time for test{guid}.db to fully… #2941

Closed
wants to merge 1 commit into from

Conversation

SteveBush
Copy link
Contributor

Pull request for bug #2940

Added code to CleanUpDb to wait for one millisecond to allow test{guid}.db to fully close. In the process made CleanUpDb async. I decided not to rename CleanUpDbAsync which I would normally have done.

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2023

CLA assistant check
All committers have signed the CLA.

@iancooper
Copy link
Member

Thanks for this.

@iancooper
Copy link
Member

@SteveBush At this point we are committing to the v9 branch and then re-basing main so that fixes go into both versions whilst preserving history. I can handle this for you in this case.

@SteveBush
Copy link
Contributor Author

@SteveBush At this point we are committing to the v9 branch and then re-basing main so that fixes go into both versions whilst preserving history. I can handle this for you in this case.

Sounds great. You might also consider adding an Async to CleanUpDbAsync depending on your method naming style as I added an async modifier. I’m new to your project so I’m still learning your coding style. Lot’s of great work.

@iancooper
Copy link
Member

You might also consider adding an Async to CleanUpDbAsync

yeah that tends to be our style

@iancooper
Copy link
Member

@SteveBush This change should have been applied via V9. Do you want to check, and then I will close this PR?

@SteveBush
Copy link
Contributor Author

@SteveBush This change should have been applied via V9. Do you want to check, and then I will close this PR?

Yes. Thank you. I have verified that 47d5c90 fixes the issue.

@iancooper iancooper closed this Dec 13, 2023
@SteveBush SteveBush deleted the bug-2940 branch December 13, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants