-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-1612 Release Notes Page #474
Conversation
Pull Request Test Coverage Report for Build 11059991612Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks super solid to me! Great job! I just commented two questions I had and one suggestion. Feel free to disregard all comments if you feel otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
This PR primarily adds a dynamically-fetched Release Notes page from our CHANGELOG.md document. In order to ensure each release/tier reflects accurate release notes, we fetch the CHANGELOG.md from GitHub based on the Build Tag (
REACT_APP_FE_VERSION
variable).Additionally, it introduces a debug logging wrapper, which can be used to safely output errors to the console. This wrapper intentionally does not emit output during testing to prevent test failures. While this wrapper currently just outputs to the console, it can be expanded in the future to send logs to an external collector.
Note
In order to test this locally, define the ENV variable
REACT_APP_FE_VERSION
as3.1.0.410
(or later), which is the first build with release notes.Change Details (Specifics)
(Related to requirements)
(Supporting changes)
console.xxx
functionsx
Related Ticket(s)
CRDCDH-1612 (This FE task)
CRDCDH-1615 (Markdown Document Task)
CRDCDH-1532 (User Story)