Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shader Line Annotation and Error Remapping #2691

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Shader Line Annotation and Error Remapping #2691

wants to merge 1 commit into from

Conversation

douira
Copy link
Collaborator

@douira douira commented Aug 19, 2024 •
edited
Loading

  • add line directive insertion to ShaderParser,
  • use assigned source ids to remap the sources in shader compilation logs,
  • print merged shader sources to the log file in dev environments

Fixes #2680

@douira
add line directive insertion to ShaderParser,
2392786 
use assigned source ids to remap the sources in shader compilation logs,
print merged shader sources to the log file in dev environments
@douira
Copy link
Collaborator Author

douira commented Aug 19, 2024

Please test if the included regex of the form \d+:\d+: works for the shader compilation logs produced by other drivers. If not, I'll adjust the regex to also match those. Also please test that the line numbers produced in the errors actually correspond to the line numbers in the source files, to make sure the drivers aren't interpreting the line directive differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IMS212 IMS212 Awaiting requested review from IMS212

@jellysquid3 jellysquid3 Awaiting requested review from jellysquid3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add line numbers to merged shader sources and improve the debugging experience
1 participant
@douira