Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompts/popups use translation strings #2283

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

Madis0
Copy link
Contributor

@Madis0 Madis0 commented Jan 28, 2024

Makes several string literals use Sodium's or Minecraft's locale strings.

Affected:

  • Prompts in general
  • Donation prompts specifically
  • Config corruption popup
  • Chunk update threads slider

I didn't change the RTSS and jar running stuff because I think these would not work the same way.

The changes have been tested and are working.

"sodium.options.buttons.donate": "Buy us a coffee!",
"sodium.prompt.donate.contents": "Hello!\n\nIt seems that you've been enjoying §x27eb92Sodium§r, the free and open-source optimization mod for Minecraft.\n\nMods like these are complex. They require §xff6e00thousands of hours§r of development, debugging, and tuning to create the experience that players have come to expect.\n\nIf you'd like to show your token of appreciation, and support the development of our mod in the process, then consider §xed49cebuying us a coffee§r.\n\nAnd thanks again for using our mod! We hope it helps you (and your computer.)",
"sodium.prompt.donate.action": "Buy us a coffee",
Copy link
Contributor Author

@Madis0 Madis0 Jan 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally separate string from ln 59 because the prompt action can be different from the static button (#2008)

@Madis0 Madis0 changed the title Change literals into translatables Prompts/popups use translation strings Jan 28, 2024
@jellysquid3 jellysquid3 added this to the Sodium 0.5.8 milestone Jan 29, 2024
@jellysquid3 jellysquid3 modified the milestones: Sodium 0.5.8, Sodium 0.5.9 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants