Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider) - Label showing all the time instead of using marker #2528

Merged

Conversation

Alex-NRCan
Copy link
Member

@Alex-NRCan Alex-NRCan commented Sep 30, 2024

Description

  • Default stepping value for time-slider to 1 day;
  • New style on the active thumb to visually indicate that it's selected and can be moved by keyboard;
  • Small style change on the label (make it a bit smaller);
  • Renaming 'onValueDisplay' to 'onValueLabelFormat' to better align with 'onValueLabelFormat' that comes from Material UI and to better distinguish from 'valueLabelDisplay' (from Material UI) which has different meaning
  • Added support for disableSwap and labelSpread attributes
  • Cleaned up attributes spreading on the Component

This PR has breaking changes with regards to the Slider component. The Slider component should be retested everywhere that it's used in GeoView.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Hosted here as of Oct. 2nd @ 11h00 : https://alex-nrcan.github.io/geoview/demos-navigator.html?config=./configs/navigator/10-package-time-slider.json

This PR has breaking changes with regards to the Slider component. The Slider component should be retested everywhere that it's used in GeoView.

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

Copy link
Member Author

@Alex-NRCan Alex-NRCan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jolevesq)

@Alex-NRCan Alex-NRCan force-pushed the fix-slider branch 2 times, most recently from 9796bd2 to 3336eb9 Compare October 2, 2024 14:25
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)

- New style on the active thumb to visually indicate that it's selected and can be moved by keyboard;
- Small style change on the label (make it a bit smaller);
- Renaming 'onValueDisplay' to 'onValueLabelFormat' to better align with 'onValueLabelFormat' that comes from Material UI and to better distinguish from 'valueLabelDisplay' (from Material UI) which has different meaning
- Disable thumb swapping and label spreading when more than 2 thumbs now native in the GeoView Slider component
@jolevesq jolevesq merged commit 45a1041 into Canadian-Geospatial-Platform:develop Oct 2, 2024
6 checks passed
@Alex-NRCan Alex-NRCan deleted the fix-slider branch October 2, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants