-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add triangle/ray and gltf/ray intersect function with tests #777
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Still more work to do in the implementation...
Also add the source python that created them
I'm thinking we should make this a separate issue, and not handle it for this PR. I do have opinions of course (like letting the OBB constructor code throw), but this feels like something to be discussed outside of ray intersection tests. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@kring Ready for one more pass! |
Looks good, thanks! I'll merge as soon as CI passes. |
Added two new utility functions,
rayTriangle
andintersectRayGltfModel
. They have unit tests to verify their correctness.This PR can really be thought of as two distinct efforts: