Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add triangle/ray and gltf/ray intersect function with tests #777

Merged
merged 88 commits into from
Jul 25, 2024
Merged

Add triangle/ray and gltf/ray intersect function with tests #777

merged 88 commits into from
Jul 25, 2024

Commits on Dec 13, 2023

  1. add gltf ray intersect function with tests

    Joseph Kaile committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    ad512a3 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. add more intersection tests

    Joseph Kaile committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    12d6885 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Merge branch 'main' into gltf-ray-intersect

    Joseph Kaile committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    ed52c05 View commit details
    Browse the repository at this point in the history

  2. update and comment intersection functions

    Joseph Kaile committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    c6bcf97 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. update from main

    @csciguy8
    csciguy8 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b765a73 View commit details
    Browse the repository at this point in the history

  2. revert changes

    @csciguy8
    csciguy8 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    0ad3192 View commit details
    Browse the repository at this point in the history

  3. revert draco change

    @csciguy8
    csciguy8 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e55105c View commit details
    Browse the repository at this point in the history

  4. revert ktx software change

    @csciguy8
    csciguy8 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6143a7e View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Add more hit result info to ::intersectRayGltfModel 

    Still more work to do in the implementation...
    @csciguy8
    csciguy8 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    54da172 View commit details
    Browse the repository at this point in the history

  2. Let intersectRayGltfModel HitResult return meshId correctly

    @csciguy8
    csciguy8 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    5bcfe34 View commit details
    Browse the repository at this point in the history

  3. Let intersectRayGltfModel HitResult return primitiveId correctly

    @csciguy8
    csciguy8 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    ccce2f0 View commit details
    Browse the repository at this point in the history

  4. Store primitiveToWorld transform in the hit result

    @csciguy8
    csciguy8 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a01ef4c View commit details
    Browse the repository at this point in the history

  5. Add missing initializers

    @csciguy8
    csciguy8 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    54b352b View commit details
    Browse the repository at this point in the history

  6. Fix primitiveToWorld not getting copied to hit result

    @csciguy8
    csciguy8 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1fed700 View commit details
    Browse the repository at this point in the history

  7. Rework tests to also traverse into model using hit results

    @csciguy8
    csciguy8 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    48db4d0 View commit details
    Browse the repository at this point in the history

  8. Fix check to not generate a warning

    @csciguy8
    csciguy8 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    39fc592 View commit details
    Browse the repository at this point in the history

  9. Fix casting warnings

    @csciguy8
    csciguy8 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    fad02b5 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Fix bug where intersect test would hit tris behind the ray. Add more … 

    …tests
    @csciguy8
    csciguy8 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f13d733 View commit details
    Browse the repository at this point in the history

  2. Fix warning

    @csciguy8
    csciguy8 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8ba0507 View commit details
    Browse the repository at this point in the history

  3. Undo unnecessary changes

    @csciguy8
    csciguy8 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c35b8d3 View commit details
    Browse the repository at this point in the history

  4. Update code documentation

    @csciguy8
    csciguy8 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    cd8edc2 View commit details
    Browse the repository at this point in the history

  5. Rename getPointAlongRay to pointFromDistance

    @csciguy8
    csciguy8 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    90755af View commit details
    Browse the repository at this point in the history

  6. Add tests for intersections with model with transformation matrix

    @csciguy8
    csciguy8 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2924ede View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Add some test glbs 

    Also add the source python that created them
    @csciguy8
    csciguy8 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    bc8a918 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. update test generation scripts

    @csciguy8
    csciguy8 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bef7cbf View commit details
    Browse the repository at this point in the history

  2. Explicitly declare triangle mode

    @csciguy8
    csciguy8 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a0b49ce View commit details
    Browse the repository at this point in the history

  3. Add cube with triangle strip test

    @csciguy8
    csciguy8 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    25331a9 View commit details
    Browse the repository at this point in the history

  4. Remove unneeded test files

    @csciguy8
    csciguy8 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    018c764 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Add cube fan example and generation script

    @csciguy8
    csciguy8 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c5ebb81 View commit details
    Browse the repository at this point in the history

  2. switch to using new unit cube test model

    @csciguy8
    csciguy8 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2e5ff62 View commit details
    Browse the repository at this point in the history

  3. Stub out the rest of the unit cube tests

    @csciguy8
    csciguy8 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1c73911 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary test asset

    @csciguy8
    csciguy8 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    938e5cd View commit details
    Browse the repository at this point in the history

  5. update format

    @csciguy8
    csciguy8 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7af2344 View commit details
    Browse the repository at this point in the history

  6. Flesh out non-indexed code path

    @csciguy8
    csciguy8 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    41ee75b View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Add non-indexed cube test and fix logic bugs

    @csciguy8
    csciguy8 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    dc0f4d6 View commit details
    Browse the repository at this point in the history

  2. Add proper support for triangle strips and enable test

    @csciguy8
    csciguy8 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    b0a92ff View commit details
    Browse the repository at this point in the history

  3. Add indexed triangle strip test cube

    @csciguy8
    csciguy8 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    331cd18 View commit details
    Browse the repository at this point in the history

  4. Add proper support for indexed triangle strips and enable test

    @csciguy8
    csciguy8 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    aedb8cc View commit details
    Browse the repository at this point in the history

  5. Add triangle fan support and enable test

    @csciguy8
    csciguy8 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    1318561 View commit details
    Browse the repository at this point in the history

  6. Add indexed triangle fan test cube

    @csciguy8
    csciguy8 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    7ea3f2e View commit details
    Browse the repository at this point in the history

  7. Add proper support for indexed triangle fans and enable test

    @csciguy8
    csciguy8 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e3320e4 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Fix bug where ray AABB test would always miss (missing .transform call)

    @csciguy8
    csciguy8 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1734847 View commit details
    Browse the repository at this point in the history

  2. Update code doc

    @csciguy8
    csciguy8 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9b0640d View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Fix bug where a scaled gltf would produce incorrect hit results. Add … 

    …test.
    @csciguy8
    csciguy8 committed May 30, 2024
    Configuration menu
    Copy the full SHA
    cab5d1e View commit details
    Browse the repository at this point in the history

  2. Update code doc

    @csciguy8
    csciguy8 committed May 30, 2024
    Configuration menu
    Copy the full SHA
    5a50038 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Use ::createAccessorView to clean up handling of index format variations

    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    84eb490 View commit details
    Browse the repository at this point in the history

  2. let findClosestIndexedRayHit specify a templated AccessorView for ind… 

    …ices, for clarity
    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    905eb94 View commit details
    Browse the repository at this point in the history

  3. Add checks for invalid indices. Fix casting for AccessorView operations

    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a9c5658 View commit details
    Browse the repository at this point in the history

  4. Ignore float component types for index buffers

    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    402a485 View commit details
    Browse the repository at this point in the history

  5. Add rejection of non-float positions

    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    d4ec50d View commit details
    Browse the repository at this point in the history

  6. Fix bug where intersecting gltfs with nodes with different scaling co… 

    …uld produce incorrect results

Also unify the ::intersectRayGltfModel and ::intersectRayGltfModelParametric functions. We don't really need two anymore
    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5d72dcf View commit details
    Browse the repository at this point in the history

  7. Update comments from peer review

    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    b0b48bd View commit details
    Browse the repository at this point in the history

  8. warning fix

    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    dcee2c8 View commit details
    Browse the repository at this point in the history

  9. update from main

    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    aa95514 View commit details
    Browse the repository at this point in the history

  10. formatting

    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    847763e View commit details
    Browse the repository at this point in the history

  11. revert unintentional change

    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    014a3c3 View commit details
    Browse the repository at this point in the history

  12. More warnings fixes and cleanup

    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5092d26 View commit details
    Browse the repository at this point in the history

  13. Remove redundant move (build warning)

    @csciguy8
    csciguy8 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    dfea268 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Add quantized cube test data

    @csciguy8
    csciguy8 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    2fd0b3a View commit details
    Browse the repository at this point in the history

  2. Add support for gltf quantized mesh extension (non-float positions)

    @csciguy8
    csciguy8 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7b58901 View commit details
    Browse the repository at this point in the history

  3. Fix bug where first triangle in strip would get skipped

    @csciguy8
    csciguy8 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    1854ecf View commit details
    Browse the repository at this point in the history

  4. Change iteration cadence to protect against incomplete triangles

    @csciguy8
    csciguy8 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    31aeae7 View commit details
    Browse the repository at this point in the history

  5. Change index component types for more unit test coverage

    @csciguy8
    csciguy8 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7bdd210 View commit details
    Browse the repository at this point in the history

  6. Add cube translation test generated from script

    @csciguy8
    csciguy8 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7c291b5 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into gltf-ray-intersect

    @csciguy8
    csciguy8 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    1f6ac44 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Rework result of intersect function to include warnings for malformed… 

    … gltfs
    @csciguy8
    csciguy8 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    df5a3a5 View commit details
    Browse the repository at this point in the history

  2. Add intentionally invalid models, and corresponding unit tests

    @csciguy8
    csciguy8 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    6731089 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge branch 'main' into gltf-ray-intersect

    @csciguy8
    csciguy8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    728668a View commit details
    Browse the repository at this point in the history

  2. Update CHANGES.md

    @csciguy8
    csciguy8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    aece17c View commit details
    Browse the repository at this point in the history

  3. Change int to int32_t when specifying an ID

    @csciguy8
    csciguy8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ca25ad4 View commit details
    Browse the repository at this point in the history

  4. Update CHANGES.md

    @csciguy8
    csciguy8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5754226 View commit details
    Browse the repository at this point in the history

  5. update cullBackFaces doc

    @csciguy8
    csciguy8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4f47b7b View commit details
    Browse the repository at this point in the history

  6. Change some occurrences of double 1 to 1.0

    @csciguy8
    csciguy8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    04f17a3 View commit details
    Browse the repository at this point in the history

  7. Add some missing this-> code

    @csciguy8
    csciguy8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    9a4073f View commit details
    Browse the repository at this point in the history

  8. Remove duplicate implementations of ::readFile

    @csciguy8
    csciguy8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    16d18a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Remove unneeded decltypes

    @csciguy8
    csciguy8 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    888f611 View commit details
    Browse the repository at this point in the history

  2. Remove occurrences of including <glm/mat4x4.hpp> in header files

    @csciguy8
    csciguy8 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7cda07f View commit details
    Browse the repository at this point in the history

  3. Optimize by normalizing a vec3 instead of a vec4

    @csciguy8
    csciguy8 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    523f74f View commit details
    Browse the repository at this point in the history

  4. Update documentation and hit result cleanup

    @csciguy8
    csciguy8 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2e6695d View commit details
    Browse the repository at this point in the history

  5. Replace assert with getSafe for index accessor

    @csciguy8
    csciguy8 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7f2d18b View commit details
    Browse the repository at this point in the history

  6. Rewrite to not rely on != 1.0 checks

    @csciguy8
    csciguy8 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3b6c5a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'main' into gltf-ray-intersect

    @kring
    kring authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8b9b001 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Revert changes to ForEachPrimitiveInSceneXXX callbacks

    @csciguy8
    csciguy8 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d03181a View commit details
    Browse the repository at this point in the history

  2. Revert another unneeded change

    @csciguy8
    csciguy8 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a4fab06 View commit details
    Browse the repository at this point in the history

  3. formatting

    @csciguy8
    csciguy8 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5cb0d5e View commit details
    Browse the repository at this point in the history

  4. let rayTriangleParametric return an optional

    @csciguy8
    csciguy8 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7b5382e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Change rayAABBParametric to return a std optional

    @csciguy8
    csciguy8 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6213047 View commit details
    Browse the repository at this point in the history

  2. Get rid of more t return params, update docs

    @csciguy8
    csciguy8 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1fa8ee4 View commit details
    Browse the repository at this point in the history