cleanup: Remove VoxelPrimitive.jitter option (#11913) #12146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In VoxelPrimitive.js I removed the following code blocks:
/**
*/
this._jitter = false;
/**
Gets or sets whether or not to jitter the view ray during the raymarch.
This reduces stair-step artifacts but introduces noise.
@memberof VoxelPrimitive.prototype
@type {boolean}
*/
jitter: {
get: function () {
return this._jitter;
},
set: function (jitter) {
//>>includeStart('debug', pragmas.debug);
Check.typeOf.bool("jitter", jitter);
//>>includeEnd('debug');
if (this._jitter !== jitter) {
this._jitter = jitter;
this._shaderDirty = true;
}
},
},
In VoxelRenderResources.js I removed the following code block:
if (primitive._jitter) {
shaderBuilder.addDefine("JITTER", undefined, ShaderDestination.FRAGMENT);
}
In VoxelPrimitiveSpec.js I removed the following line from the test "toggles render options that require shader rebuilds":
toggleOption("jitter", false, true);
This was a cleanup issue #11913
Issue number and link
Issue #11913
Testing plan
I ran npm run test prior to making any changes in the codebase and it showed 11 failing tests, I ran it again after making changes and it had the same failing tests. This was all done in the terminal, I then ran the tests through the browser, and it showed one failing test. I'm not sure if that is just in my environment. If they fail in the workflow I may need some additional guidance.
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my changeIf approved this will close issue #11913