Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove VoxelPrimitive.jitter option (#11913) #12146

Merged
merged 3 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

- Exposes `ScreenSpaceCameraController.zoomFactor` to allow adjusting the zoom factor (speed). [#9145](https://github.com/CesiumGS/cesium/pull/9145)

- Removed `jitter` option from `VoxelPrimitive.js` and related test code in `VoxelPrimitiveSpec.js`. [#11913](https://github.com/CesiumGS/cesium/issues/11913)
okrayum marked this conversation as resolved.
Show resolved Hide resolved

##### Fixes :wrench:

- Fixed cube-mapping artifacts in image-based lighting. [#12100](https://github.com/CesiumGS/cesium/pull/12100)
Expand Down
29 changes: 0 additions & 29 deletions packages/engine/Source/Scene/VoxelPrimitive.js
Original file line number Diff line number Diff line change
Expand Up @@ -332,12 +332,6 @@ function VoxelPrimitive(options) {
this._transformNormalLocalToWorld = new Matrix3();

// Rendering
/**
* @type {boolean}
* @private
*/
this._jitter = false;

/**
* @type {boolean}
* @private
Expand Down Expand Up @@ -704,29 +698,6 @@ Object.defineProperties(VoxelPrimitive.prototype, {
},
},

/**
* Gets or sets whether or not to jitter the view ray during the raymarch.
* This reduces stair-step artifacts but introduces noise.
*
* @memberof VoxelPrimitive.prototype
* @type {boolean}
*/
jitter: {
get: function () {
return this._jitter;
},
set: function (jitter) {
//>>includeStart('debug', pragmas.debug);
Check.typeOf.bool("jitter", jitter);
//>>includeEnd('debug');

if (this._jitter !== jitter) {
this._jitter = jitter;
this._shaderDirty = true;
}
},
},

/**
* Gets or sets the nearest sampling.
*
Expand Down
1 change: 0 additions & 1 deletion packages/engine/Specs/Scene/VoxelPrimitiveSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ describe(
});

toggleOption("depthTest", true, false);
toggleOption("jitter", false, true);
toggleOption("nearestSampling", false, true);
});

Expand Down