Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changes for iTwin PRs #12407

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Update changes for iTwin PRs #12407

merged 4 commits into from
Jan 2, 2025

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Jan 2, 2025

Description

Due to some last minute PR dancing the changelog for the itwin integrations in #12334 and #12344 got mixed up a little. This PR sorts that out.

Testing plan

Check that Changes.md aligns with the timeline of changes now.

@jjspace jjspace requested a review from ggetz January 2, 2025 19:04
Copy link

github-actions bot commented Jan 2, 2025

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this fixed up @jjspace!

@@ -4,6 +4,7 @@

##### Fixes :wrench:

- Expanded the integration with the [iTwin Platform](https://developer.bentley.com/) to load GeoJSON and KML data from the Reality Management API. Use `ITwinData.createDataSourceForRealityDataId(iTwinId, realityDataId)` to load data as the corresponding Data Source. [#12344](https://github.com/CesiumGS/cesium/pull/12344)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this belong under Additions rather than Fixes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 yes, fixed

@ggetz
Copy link
Contributor

ggetz commented Jan 2, 2025

Thank you @jjspace!

@ggetz ggetz added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit abae345 Jan 2, 2025
5 checks passed
@ggetz ggetz deleted the itwin-reality-data-changelog branch January 2, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants