Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix #687): links are functional it is not direction on 404 page. #688

Merged
merged 1 commit into from
Feb 9, 2024
Merged

(fix #687): links are functional it is not direction on 404 page. #688

merged 1 commit into from
Feb 9, 2024

Conversation

subhamkumarr
Copy link
Contributor

@subhamkumarr subhamkumarr commented Feb 1, 2024 •
edited
Loading

Fixes: links are now functional. It is not directed to the 404 page.

Issue Link(s): #687

Screenshots After changes:

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Sample preview link added (add the link(s) for all the pages changed/updated from the checks tab after checks complete)
  • Tried Squashing the commits into one

@subhamkumarr
Copy link
Contributor Author

subhamkumarr commented Feb 3, 2024 •
edited
Loading

@tachyons @tanmoysrt Could you please review my PR.

@subhamkumarr subhamkumarr mentioned this pull request Feb 4, 2024
Closed
@subhamkumarr
Copy link
Contributor Author

@tanmoysrt, it's been more than a weeks. Could you please review it?

@tachyons tachyons merged commit 88a89fc into CircuitVerse:master Feb 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subhamkumarr @tachyons