Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component API to adhere to HTML standard microsyntaxes #201

Open
maxatdetroit opened this issue Apr 19, 2024 · 0 comments
Open

Update component API to adhere to HTML standard microsyntaxes #201

maxatdetroit opened this issue Apr 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@maxatdetroit
Copy link
Member

maxatdetroit commented Apr 19, 2024

Is your feature request related to a problem? Please describe.

We have some components that handle attribute values in non-standard ways.

For example, our <cod-button> component has data-disable which expects boolean value of true or false but should really conform to the HTML standard of boolean attributes.

Describe the solution you'd like

Generally speaking, we should update our component APIs to adhere to all HTML standard microsyntaxes. Specifically, the following microstandards are relevant to our components:

Also, unless the attribute is a boolean attribute, the component should treat attribute="undefined" or attribute="" the same as omitting the attribute entirely. In Storybook stories, we should prefer omitting the attribute entirely if the storybook control is not set.

This issue is to go through all components and update each attribute that resembles these microsyntaxes to adhere to the standard.

Work breakdown

It'll help us avoid merge conflicts if we break down the work this way per component. Components are distributed in this spreadsheet: https://is.gd/ETzUCF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants