Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruning the old to-hit syntax - Part 11 #77838

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Nov 14, 2024

Summary

None

Purpose of change

Continuation from #77815

Describe the solution

Affected files include:

  • book\abstract.json
  • containers\generic.json
  • corpses\dead_exodii.json
  • corpses\dead_yrax.json
  • corpses\inactive_bots.json
  • furniture\seating.json
  • generic\bathroom_house.json
  • generic\bedding.json
  • generic\dining_kitchen.json
  • generic\spares.json
  • generic\storage.json
  • generic\toys_and_sports.json

Other things of note:

  • Pool balls are now no longer useful when used in melee, only doing damage when thrown
  • Utensils and silverware lost their weird bash damage they had for some reason
  • I added some token bash damage to furniture items while I was here
  • Removed all tohit and damage lines from robots that are too large to reasonably swing. This especially goes to golden monoliths with their bullshit 1000 bash damage
  • Other damage value adjustments were also included, but that goes for most of those PRs. The rules I go by are explained in one of my first PRs from this series

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 14, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 15, 2024
@harakka
Copy link
Member

harakka commented Nov 15, 2024

Thank you for doing the corpse thing ❤️

@Night-Pryanik Night-Pryanik merged commit 4f476ed into CleverRaven:master Nov 15, 2024
17 of 24 checks passed
@Karol1223 Karol1223 deleted the moretohit branch November 15, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants