Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more nests to the roof palette #77864

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

Milopetilo
Copy link
Contributor

@Milopetilo Milopetilo commented Nov 15, 2024

Summary

Infrastructure "Roof palette has more built-in nests"

Purpose of change

Noticed some roofs used symbols for adding nests that were already in use by roof_palette and so sometimes spawned furniture instead of nothing. This also adds water heaters to roof_palette and cleans up a roof nest.
This also fixes an issue where motels spawned with solar panels in the windows.

Describe the solution

Add most nests available in nested_chunks_roof to roof_palette. Go over every usage of the palette to make sure no overlap happens and change the symbol if it does occur.

Describe alternatives you've considered

Go over every roof and make sure no symbols overlap with the palette.

Testing

Game loads, roofs look the same and don't have nests erroneously.

Additional context

Will follow this up with making all roofs use the nests introduced here.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 15, 2024
@Maleclypse Maleclypse merged commit 0f2c155 into CleverRaven:master Nov 15, 2024
20 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants