Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Dont extract monster/fake spells for translation #77869

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

Uwuewsky
Copy link
Contributor

Summary

I18N "[Magiclysm] NO_I18N, dont extract monster/fake spells"

Purpose of change

Many fake spells or monster-only spells are extracted for translation.

Describe the solution

Flag these spells to skip extraction.
Add PREFIX_XL/XS to a couple things as it was done for the base game.

Describe alternatives you've considered

Testing

The game loads correctly. Marked strings are now missing from .pot file. Changed items still have the correct names:
mag1
mag2
mag3

Additional context

@github-actions github-actions bot added Translation I18n [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Monsters Monsters both friendly and unfriendly. Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells Items: Armor / Clothing Armor and clothing labels Nov 15, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 15, 2024
@Maleclypse Maleclypse merged commit 45a67ea into CleverRaven:master Nov 15, 2024
19 of 26 checks passed
@Uwuewsky Uwuewsky deleted the no-i18n-mag branch November 15, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Monsters Monsters both friendly and unfriendly. Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Translation I18n Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants