Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Multiple Anvils for Isherwood Mission #77931

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheMurderUnicorn
Copy link
Contributor

@TheMurderUnicorn TheMurderUnicorn commented Nov 17, 2024

Summary

Bugfixes "Enable Other Anvils for Isherwood Quest"

Purpose of change

#77908

TLDR: Missions asks for an anvil, dialogue suggests that you can use a crafted one. However, it only accepted the regular anvil. It was requested that this change to accommodate other anvils.

Describe the solution

Restructure mission using if then logic to allow for the anvil, crude anvil, bronze anvil, or heavy anvil.

Describe alternatives you've considered

Removing the dialogue suggesting craft-able anvils are acceptable and leaving it as anvil only.

Testing

Ensured no syntax errors. Verified that all anvils are acceptable/complete the mission (though it requires you to wield that larger anvils/have them in your inventory to complete, this is a flaw with the removal command, I can't fix that). Verified the anvil is removed before giving the reward, I don't know if this matters, but it makes more sense that way and figured it was safer that way.

Additional context

Okay, so a few issues. Firstly, all anvils have anvil 3 or better, making them suitable for the purpose of this quest. Therefore, I feel they should be acceptable. However, part of this mission updates the mapgen to include that anvil as furniture IN the map. I looked into changing this to accommodate which anvil you received, however I could not find an example of "then" using the update mapgen command. When attempting to do this I got various errors about it not being a valid entry for this. I don't know if I was doing it wrong or if the infrastructure isn't there.

TLDR: TODO: Figure out how to change the mapgen update to reflect which anvil is turned in for the quest.

Additionally, it was unclear to me if the bronze anvil should be valid, but seeing as we assign them the same anvil quality, presumably it is fine.
closes #77908

Screenshots:
image
image
image

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 17, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
1 participant