Enable Multiple Anvils for Isherwood Mission #77931
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Enable Other Anvils for Isherwood Quest"
Purpose of change
#77908
TLDR: Missions asks for an anvil, dialogue suggests that you can use a crafted one. However, it only accepted the regular anvil. It was requested that this change to accommodate other anvils.
Describe the solution
Restructure mission using if then logic to allow for the anvil, crude anvil, bronze anvil, or heavy anvil.
Describe alternatives you've considered
Removing the dialogue suggesting craft-able anvils are acceptable and leaving it as anvil only.
Testing
Ensured no syntax errors. Verified that all anvils are acceptable/complete the mission (though it requires you to wield that larger anvils/have them in your inventory to complete, this is a flaw with the removal command, I can't fix that). Verified the anvil is removed before giving the reward, I don't know if this matters, but it makes more sense that way and figured it was safer that way.
Additional context
Okay, so a few issues. Firstly, all anvils have anvil 3 or better, making them suitable for the purpose of this quest. Therefore, I feel they should be acceptable. However, part of this mission updates the mapgen to include that anvil as furniture IN the map. I looked into changing this to accommodate which anvil you received, however I could not find an example of "then" using the update mapgen command. When attempting to do this I got various errors about it not being a valid entry for this. I don't know if I was doing it wrong or if the infrastructure isn't there.
TLDR: TODO: Figure out how to change the mapgen update to reflect which anvil is turned in for the quest.
Additionally, it was unclear to me if the bronze anvil should be valid, but seeing as we assign them the same anvil quality, presumably it is fine.
closes #77908
Screenshots: