Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the horizontal separator color back to dark-gray #77935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moxian
Copy link
Contributor

@moxian moxian commented Nov 17, 2024

Summary

Interface "Revert horizontal separator color back to dark gray"

Purpose of change

#77842 made the imgui colors inherit from player-chosen colors, but it used blue as the color for horizontal separator in item description screen and the like instead of dark gray. I assume, accidentally, since there is no mention of such intent in the PR.
In the default fresh install the blue color is extremely bright and high contrast. It pulls attention towards itself and makes it hard [for me] to look at the item description pane for prolonged time.

This change reverts the horizontal separator color back to what it was pre-#77842

Images:
before #77842
20241117-014826-cataclysm-tiles
current master:
20241117-014522-cataclysm-tiles
with this PR in place:
20241117-014649-cataclysm-tiles

(sidenote: I'm not sure what's going on with the fonts and why the switched to monospace now, but that's out of scope)

Describe the solution

Change the separator default color from c_blue to c_dark_gray

Describe alternatives you've considered

N/A
(Well, i did consider making it much easier to customize imgui, and unbinding the "separator color" from the pre-defined colors we have in color config, but realized that it might be a task beyond my abilities atm. Besides, this PR is just a simple bugfix)

Testing

Opened item description pane, took screenshot (above), was happy with the result.

Additional context

This will likely conflict with #77928 since we both touch the same file (i'm not sure how PR conflicts are handled in this project and if i need to do anything special here. cc @mqrause just in case)

it was seemingly set to blue accidentally
@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 17, 2024
@GuardianDll
Copy link
Member

No merge conflicts because you touch different lines, github will handle it just fine

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants