Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Xedra Evolved] Dont extract fake spells/stuff for translation #77940

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Xedra Evolved] Dont extract fake spells/stuff for translation #77940

wants to merge 2 commits into from
+737 −567

Conversation

Uwuewsky
Copy link
Contributor

Summary

I18N "[Xedra Evolved] NO_I18N, dont extract monster/fake spells"

Purpose of change

Many fake spells or monster-only spells are extracted for translation.

Describe the solution

Flag these spells to skip extraction.
Add PREFIX_XL/XS to a couple things as it was done for the base game.
Fixed the names: wolf's mask (on), moon tears chainmail vest

Describe alternatives you've considered

Testing

The game loads correctly. Marked strings are now missing from .pot file. Changed items still have the correct names:
xe1
xe2

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Bionics CBM (Compact Bionic Modules) Vehicles Vehicles, parts, mechanics & interactions Items: Food / Vitamins Comestibles and drinks Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Monsters Monsters both friendly and unfriendly. Melee Melee weapons, tactics, techniques, reach attack Mechanics: Enchantments / Spells Enchantments and spells Items: Armor / Clothing Armor and clothing Mods: Xedra Evolved Anything to do with Xedra Evolved labels Nov 17, 2024
@github-actions github-actions bot added Translation I18n astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) Items: Armor / Clothing Armor and clothing Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Melee Melee weapons, tactics, techniques, reach attack Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Translation I18n Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Uwuewsky